fix: Replace http with https, drop iframe#795
Merged
Conversation
fstagni
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
There are a few places in the WebApp where http is used but https would be preferred now.
On of these references is an iframe which loads diracgrid.org behind the webapp every time, but is only actually displayed when the "cog" icon is pressed on the top left menu bar. This has a number of problems: We probably don't want it loading the page every time (extra bloat & latency) and because it was a http iframe it wouldn't load in most browsers in the last 10+ years anyway. For now I've just commented out the iframe entirely: This gives the same "blank page" user experience as we've had forever without the security warning or latency. (Perhaps we could consider removing this tab entirely? It isn't clear where it is specified).
Regards,
Simon
BEGINRELEASENOTES
FIX: Prefer https wherever possible, remove insecure iframe
ENDRELEASENOTES